From: Jeff King Date: Wed, 20 Feb 2013 20:00:59 +0000 (-0500) Subject: upload-archive: do not copy repo name X-Git-Tag: v1.8.3-rc0~148^2~14 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=6379dd052243aa6b1cc5115b72b78aedbeeed008;p=git upload-archive: do not copy repo name According to the comment, enter_repo will modify its input. However, this has not been the case since 1c64b48 (enter_repo: do not modify input, 2011-10-04). Drop the now-useless copy. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/builtin/upload-archive.c b/builtin/upload-archive.c index b928beb8ed..c3d134eac1 100644 --- a/builtin/upload-archive.c +++ b/builtin/upload-archive.c @@ -27,13 +27,8 @@ int cmd_upload_archive_writer(int argc, const char **argv, const char *prefix) if (argc != 2) usage(upload_archive_usage); - if (strlen(argv[1]) + 1 > sizeof(buf)) - die("insanely long repository name"); - - strcpy(buf, argv[1]); /* enter-repo smudges its argument */ - - if (!enter_repo(buf, 0)) - die("'%s' does not appear to be a git repository", buf); + if (!enter_repo(argv[1], 0)) + die("'%s' does not appear to be a git repository", argv[1]); /* put received options in sent_argv[] */ sent_argc = 1;