From: Christian Hofstaedtler <christian.hofstaedtler@deduktiva.com>
Date: Thu, 6 Oct 2016 21:03:17 +0000 (+0200)
Subject: serialtweaker: remove fallback, make DEFAULT an explicit choice
X-Git-Tag: dnsdist-1.3.0~168^2~2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=636301b9f15aa5eecab4282258e85503b7ea4dcf;p=pdns

serialtweaker: remove fallback, make DEFAULT an explicit choice

Improves pdnsutil increase-serial, and helps the API being more strict.
---

diff --git a/pdns/serialtweaker.cc b/pdns/serialtweaker.cc
index a8a0a01c7..8475a0c6f 100644
--- a/pdns/serialtweaker.cc
+++ b/pdns/serialtweaker.cc
@@ -78,38 +78,36 @@ uint32_t calculateEditSOA(uint32_t old_serial, DNSSECKeeper& dk, const DNSName&
 
 /** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API. */
 static uint32_t calculateIncreaseSOA(uint32_t old_serial, const string& increaseKind, const string& editKind, const DNSName& zonename) {
-  // These only work when SOA-EDIT is set, otherwise fall back to default.
-  if (!editKind.empty()) {
-    if (pdns_iequals(increaseKind, "SOA-EDIT-INCREASE")) {
-      uint32_t new_serial = calculateEditSOA(old_serial, editKind, zonename);
-      if (new_serial <= old_serial) {
-        new_serial = old_serial + 1;
-      }
-      return new_serial;
+  if (pdns_iequals(increaseKind, "SOA-EDIT-INCREASE")) {
+    uint32_t new_serial = old_serial;
+    if (!editKind.empty()) {
+      new_serial = calculateEditSOA(old_serial, editKind, zonename);
     }
-    else if (pdns_iequals(increaseKind, "SOA-EDIT")) {
-      return calculateEditSOA(old_serial, editKind, zonename);
+    if (new_serial <= old_serial) {
+      new_serial = old_serial + 1;
     }
+    return new_serial;
   }
-
-  if (pdns_iequals(increaseKind, "INCREASE")) {
+  else if (pdns_iequals(increaseKind, "SOA-EDIT")) {
+    return calculateEditSOA(old_serial, editKind, zonename);
+  }
+  else if (pdns_iequals(increaseKind, "INCREASE")) {
     return old_serial + 1;
   }
   else if (pdns_iequals(increaseKind, "EPOCH")) {
     return time(0);
   }
-
-  // DEFAULT case
-  time_t now = time(0);
-  struct tm tm;
-  localtime_r(&now, &tm);
-  boost::format fmt("%04d%02d%02d%02d");
-  string newdate = (fmt % (tm.tm_year + 1900) % (tm.tm_mon + 1) % tm.tm_mday % 1).str();
-  uint32_t new_serial = pdns_stou(newdate);
-  if (new_serial <= old_serial) {
-      new_serial = old_serial + 1;
+  else if (pdns_iequals(increaseKind, "DEFAULT")) {
+    time_t now = time(0);
+    uint32_t new_serial = localtime_format_YYYYMMDDSS(now, 1);
+    if (new_serial <= old_serial) {
+        new_serial = old_serial + 1;
+    }
+    return new_serial;
+  } else if(!increaseKind.empty()) {
+    L<<Logger::Warning<<"SOA-EDIT-API/DNSUPDATE type '"<<increaseKind<<"' for zone "<<zonename<<" is unknown."<<endl;
   }
-  return new_serial;
+  return old_serial;
 }
 
 /** Used for SOA-EDIT-DNSUPDATE and SOA-EDIT-API.