From: Stefan Bühler <stbuehler@web.de>
Date: Fri, 17 May 2013 11:21:56 +0000 (+0200)
Subject: Don't store edited soa serial for INCREMENT soa-edit kinds
X-Git-Tag: auth-3.3-rc1~29^2~6^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=63347c6c59601fe0b82e9be46a4e901aca633f79;p=pdns

Don't store edited soa serial for INCREMENT soa-edit kinds

 * simple increment for INCREMENT-WEEKS
 * increment to current day for INCEPTION-INCREMENT
---

diff --git a/pdns/dnsseckeeper.hh b/pdns/dnsseckeeper.hh
index 9dcc4f418..f290d4c10 100644
--- a/pdns/dnsseckeeper.hh
+++ b/pdns/dnsseckeeper.hh
@@ -163,6 +163,7 @@ private:
 };
 
 class DNSPacket;
+uint32_t localtime_format_YYYYMMDDSS(time_t t, uint32_t seq);
 bool editSOA(DNSSECKeeper& dk, const string& qname, DNSPacket* dp);
 uint32_t calculateEditSoa(SOAData sd, const string& kind);
 #endif
diff --git a/pdns/pdnssec.cc b/pdns/pdnssec.cc
index 17f0167f1..806d3884a 100644
--- a/pdns/pdnssec.cc
+++ b/pdns/pdnssec.cc
@@ -485,10 +485,25 @@ int increaseSerial(const string& zone, DNSSECKeeper &dk)
      cerr<<zone<<" not found!"<<endl;
   }
   
-  if (soaEditKind.empty())
+  if (soaEditKind.empty()) {
     sd.serial++;
-  else
+  }
+  else if(pdns_iequals(soaEditKind,"INCREMENT-WEEKS")) {
+    sd.serial++;
+  }
+  else if(pdns_iequals(soaEditKind,"INCEPTION-INCREMENT")) {
+    uint32_t today_serial = localtime_format_YYYYMMDDSS(time(NULL), 1);
+
+    if (sd.serial < today_serial) {
+      sd.serial = today_serial;
+    }
+    else {
+      sd.serial++;
+    }
+  }
+  else {
     sd.serial = calculateEditSoa(sd, soaEditKind) + 1;
+  }
   rrs[0].content = serializeSOAData(sd);
 
   if (! sd.db->replaceRRSet(sd.domain_id, zone, rr.qtype, rrs)) {
diff --git a/pdns/serialtweaker.cc b/pdns/serialtweaker.cc
index 7a6c5b6e3..32ec01cc2 100644
--- a/pdns/serialtweaker.cc
+++ b/pdns/serialtweaker.cc
@@ -21,7 +21,7 @@
 #include "namespaces.hh"
 #include <boost/foreach.hpp>
 
-static uint32_t localtime_format_YYYYMMDDSS(time_t t, uint32_t seq)
+uint32_t localtime_format_YYYYMMDDSS(time_t t, uint32_t seq)
 {
   struct tm tm;
   localtime_r(&t, &tm);