From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sun, 8 May 2022 23:59:16 +0000 (-0700)
Subject: graphml2gv: abbreviate an open coded 'strcat'
X-Git-Tag: 4.0.0~33^2~4
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=63294ede8bad25a640913a961fe1636923acef85;p=graphviz

graphml2gv: abbreviate an open coded 'strcat'
---

diff --git a/cmd/tools/graphml2gv.c b/cmd/tools/graphml2gv.c
index 4b948e2e4..5aafb020d 100644
--- a/cmd/tools/graphml2gv.c
+++ b/cmd/tools/graphml2gv.c
@@ -16,6 +16,7 @@
 #include    <cgraph/likely.h>
 #include    <cgraph/stack.h>
 #include    <getopt.h>
+#include    <string.h>
 #ifdef HAVE_EXPAT
 #include    <expat.h>
 #include    <ctype.h>
@@ -553,8 +554,7 @@ static void endElementHandler(void *userData, const char *name)
 		name = dynbuf = N_NEW(len, char);
 		strcpy(name, GRAPHML_COMP);
 	    }
-	    strcpy(name + sizeof(GRAPHML_COMP) - 1,
-		   agxbuse(&ud->xml_attr_name));
+	    strcat(name, agxbuse(&ud->xml_attr_name));
 	    value = agxbuse(&ud->composite_buffer);
 	    agxbclear(&ud->xml_attr_value);
 	    ud->compositeReadState = FALSE;