From: SjonHortensius <SjonHortensius@users.noreply.github.com>
Date: Thu, 19 Jan 2017 10:41:02 +0000 (+0100)
Subject: Update comment, incorrect since 224aaf94
X-Git-Tag: php-7.1.2RC1~44
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=631861e1fa93b19788def94cf456d2993551c17f;p=php

Update comment, incorrect since 224aaf94

In 224aaf94; the warning was enabled; making the comment above incorrect. I've updated the comment to reflect the current code
---

diff --git a/ext/session/session.c b/ext/session/session.c
index c06c5a3a0d..d672b0c283 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -425,8 +425,7 @@ static void php_session_initialize(void) /* {{{ */
 	php_session_track_init();
 	if (PS(mod)->s_read(&PS(mod_data), PS(id), &val, PS(gc_maxlifetime)) == FAILURE) {
 		php_session_abort();
-		/* Some broken save handler implementation returns FAILURE for non-existent session ID */
-		/* It's better to raise error for this, but disabled error for better compatibility */
+		/* FYI: Some broken save handlers return FAILURE for non-existent session ID, this is incorrect */
 		php_error_docref(NULL, E_WARNING, "Failed to read session data: %s (path: %s)", PS(mod)->s_name, PS(save_path));
 		return;
 	}