From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 15 Jan 2022 18:56:42 +0000 (-0800)
Subject: API BREAK: use a C99 bool for 'Agraphinfo.has_sourcerank'
X-Git-Tag: 3.0.0~66^2~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=62f6246e47f2654da527cf8b4324f3fbc229660e;p=graphviz

API BREAK: use a C99 bool for 'Agraphinfo.has_sourcerank'
---

diff --git a/CHANGELOG.md b/CHANGELOG.md
index de3a8f5a3..36317e256 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -28,8 +28,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   now C99 `bool`s instead of Graphviz-specific `boolean`s.
 - **Breaking**: The `filled`, `landscape`, and `centered` fields of the
   `layout_t` struct are now C99 `bool`s instead of Graphviz-specific `boolean`s.
-- **Breaking**: The `has_images` and `has_flat_edges` fields of the
-  `Agraphinfo_t` struct are now C99 `bool`s instead of Graphviz-specific
+- **Breaking**: The `has_images`, `has_flat_edges`, and `has_sourcerank` fields
+  of the `Agraphinfo_t` struct are now C99 `bool`s instead of Graphviz-specific
   `boolean`s.
 - **Breaking**: Graphviz headers no longer define the constant `MAXSHORT`. A
   drop-in replacement is `SHRT_MAX` in the C standard library’s limits.h.
diff --git a/lib/common/types.h b/lib/common/types.h
index 4b95692e8..f24df6176 100644
--- a/lib/common/types.h
+++ b/lib/common/types.h
@@ -323,7 +323,7 @@ typedef enum {NATIVEFONTS,PSFONTS,SVGFONTS} fontname_kind;
 
 	/* various flags */
 	bool has_flat_edges;
-	boolean has_sourcerank;
+	bool has_sourcerank;
 	boolean has_sinkrank;
 	unsigned char	showboxes;
 	fontname_kind fontnames;		/* to override mangling in SVG */
diff --git a/lib/dotgen/rank.c b/lib/dotgen/rank.c
index edddd5c44..928cc688f 100644
--- a/lib/dotgen/rank.c
+++ b/lib/dotgen/rank.c
@@ -711,7 +711,7 @@ static void compile_samerank(graph_t * ug, graph_t * parent_clust)
     /* process this subgraph as a rankset */
     switch (rankset_kind(ug)) {
     case SOURCERANK:
-	GD_has_sourcerank(clust) = TRUE;	/* fall through */
+	GD_has_sourcerank(clust) = true;	/* fall through */
     case MINRANK:
 	leader = union_all(ug);
 	if (clust != NULL) {