From: David Kastrup Date: Sat, 8 Feb 2014 09:19:26 +0000 (+0100) Subject: builtin/blame.c::prepare_lines: fix allocation size of sb->lineno X-Git-Tag: v2.0.0-rc0~149^2~2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=62cf3ca95a7b34dcbf22d9ba4b2ea56f9fb739c9;p=git builtin/blame.c::prepare_lines: fix allocation size of sb->lineno If we are calling xrealloc on every single line, the least we can do is get the right allocation size. Signed-off-by: David Kastrup Signed-off-by: Junio C Hamano --- diff --git a/builtin/blame.c b/builtin/blame.c index ead614823e..9566a5ea4e 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -1763,7 +1763,7 @@ static int prepare_lines(struct scoreboard *sb) while (len--) { if (bol) { sb->lineno = xrealloc(sb->lineno, - sizeof(int *) * (num + 1)); + sizeof(int) * (num + 1)); sb->lineno[num] = buf - sb->final_buf; bol = 0; } @@ -1773,7 +1773,7 @@ static int prepare_lines(struct scoreboard *sb) } } sb->lineno = xrealloc(sb->lineno, - sizeof(int *) * (num + incomplete + 1)); + sizeof(int) * (num + incomplete + 1)); sb->lineno[num + incomplete] = buf - sb->final_buf; sb->num_lines = num + incomplete; return sb->num_lines;