From: Jeff Trawick <trawick@apache.org>
Date: Thu, 4 May 2006 11:18:45 +0000 (+0000)
Subject: Stop returning DECLINED from the output filter for proxy
X-Git-Tag: 2.3.0~2406
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=629975eba48656b6861fc9cf9bf89697c3462cb4;p=apache

Stop returning DECLINED from the output filter for proxy
requests.

Filters can't return that type of status.

The way to decline filter handling is to pass through the input
data unchanged and hopefully remove the output filter
permanently.

As long as the proxy flag was set in the fixup hook, we
didn't fill in our request config and the filter will be
a no-op anyway.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@399665 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/filters/mod_charset_lite.c b/modules/filters/mod_charset_lite.c
index 666cff3aec..2e8a9e0942 100644
--- a/modules/filters/mod_charset_lite.c
+++ b/modules/filters/mod_charset_lite.c
@@ -825,9 +825,6 @@ static apr_status_t xlate_out_filter(ap_filter_t *f, apr_bucket_brigade *bb)
         }
     }
 
-    /* catch proxy requests */
-    if (f->r->proxyreq) return DECLINED;
-
     /* Opening the output translation (this used to be done in the fixup hook,
      * but that was too early: a subsequent type modification, e.g., by a
      * CGI script, would go unnoticed. Now we do it in the filter itself.)