From: Tom Lane Date: Sun, 5 May 2019 16:44:32 +0000 (-0400) Subject: Add check for syscache lookup failure in update_relispartition(). X-Git-Tag: REL_12_BETA1~129 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=62148c3520b562e518f17134b22120bab0cb113b;p=postgresql Add check for syscache lookup failure in update_relispartition(). Omitted in commit 05b38c7e6 (though it looks like the original blame belongs to 9e9befac4). A failure is admittedly unlikely, but if it did happen, SIGSEGV is not the approved method of reporting it. Per Coverity. Back-patch to v11 where the broken code originated. --- diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index fabba3bacd..26f3b2cd7a 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -3451,10 +3451,11 @@ update_relispartition(Oid relationId, bool newval) classRel = table_open(RelationRelationId, RowExclusiveLock); tup = SearchSysCacheCopy1(RELOID, ObjectIdGetDatum(relationId)); + if (!HeapTupleIsValid(tup)) + elog(ERROR, "cache lookup failed for relation %u", relationId); Assert(((Form_pg_class) GETSTRUCT(tup))->relispartition != newval); ((Form_pg_class) GETSTRUCT(tup))->relispartition = newval; CatalogTupleUpdate(classRel, &tup->t_self, tup); heap_freetuple(tup); - table_close(classRel, RowExclusiveLock); }