From: Junio C Hamano Date: Mon, 23 Jun 2014 21:27:36 +0000 (-0700) Subject: builtin/clone.c: detect a clone starting at a tag correctly X-Git-Tag: v2.0.2~1^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=60a5f5fc791d6c133732238736ef0961df600296;p=git builtin/clone.c: detect a clone starting at a tag correctly 31b808a0 (clone --single: limit the fetch refspec to fetched branch, 2012-09-20) tried to see if the given "branch" to follow is actually a tag at the remote repository by checking with "refs/tags/" but it incorrectly used strstr(3); it is actively wrong to treat a "branch" "refs/heads/refs/tags/foo" and use the logic for the "refs/tags/" ref hierarchy. What the code really wanted to do is to see if it starts with "refs/tags/". Signed-off-by: Junio C Hamano --- diff --git a/builtin/clone.c b/builtin/clone.c index 9b3c04d914..545105a86f 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -695,7 +695,7 @@ static void write_refspec_config(const char* src_ref_prefix, if (option_mirror || !option_bare) { if (option_single_branch && !option_mirror) { if (option_branch) { - if (strstr(our_head_points_at->name, "refs/tags/")) + if (starts_with(our_head_points_at->name, "refs/tags/")) strbuf_addf(&value, "+%s:%s", our_head_points_at->name, our_head_points_at->name); else