From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 30 Jun 2017 16:22:33 +0000 (-0400)
Subject: Check for error during PQendcopy.
X-Git-Tag: REL_10_BETA2~48
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=609fa63db6d1e1f2c27a6dd31e9ac8d3b7bcae03;p=postgresql

Check for error during PQendcopy.

Oversight in commit 78c8c8143; noted while nosing around the
walreceiver startup/shutdown code.
---

diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
index 2f0ed035fc..93dd7b5c17 100644
--- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -459,7 +459,10 @@ libpqrcv_endstreaming(WalReceiverConn *conn, TimeLineID *next_tli)
 		PQclear(res);
 
 		/* End the copy */
-		PQendcopy(conn->streamConn);
+		if (PQendcopy(conn->streamConn))
+			ereport(ERROR,
+					(errmsg("error while shutting down streaming COPY: %s",
+							pchomp(PQerrorMessage(conn->streamConn)))));
 
 		/* CommandComplete should follow */
 		res = PQgetResult(conn->streamConn);