From: Bert Hubert <bert.hubert@netherlabs.nl>
Date: Sat, 15 Nov 2008 19:58:30 +0000 (+0000)
Subject: make single threaded mode more resilient against exceptions - thanks Daniel Drown
X-Git-Tag: rec-3.2~250
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5fe21f79d1f0c7c59a53501295cd87aaa22e3f61;p=pdns

make single threaded mode more resilient against exceptions - thanks Daniel Drown


git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@1272 d19b8d6e-7fed-0310-83ef-9ca221ded41b
---

diff --git a/pdns/distributor.hh b/pdns/distributor.hh
index 23c99c2a4..f882be621 100644
--- a/pdns/distributor.hh
+++ b/pdns/distributor.hh
@@ -241,7 +241,22 @@ template<class Answer, class Question, class Backend>int Distributor<Answer,Ques
     }
     Answer *a;
 
-    a=b->question(q);
+    try {
+      a=b->question(q); // a can be NULL!
+    }
+    catch(const AhuException &e) {
+      L<<Logger::Error<<"Backend error: "<<e.reason<<endl;
+      delete b;
+      b=0;
+      return 0;
+    }
+    catch(...) {
+      L<<Logger::Error<<Logger::NTLog<<"Caught unknown exception in Distributor thread "<<(unsigned long)pthread_self()<<endl;
+      delete b;
+      b=0;
+      return 0;
+    }
+
 
     AnswerData AD;
     AD.A=a;
diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index 978bc7478..0ad14b802 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -196,7 +196,7 @@ int PacketHandler::doDNSCheckRequest(DNSPacket *p, DNSPacket *r, string &target)
   DNSResourceRecord rr;
 
   if (p->qclass == 3 && p->qtype.getName() == "HINFO") {
-    rr.content = "PowerDNS $Id$";
+    rr.content = "\"PowerDNS\" \"$Id$\"";
     rr.ttl = 5;
     rr.qname=target;
     rr.qtype=13; // hinfo