From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Sun, 4 Feb 1996 07:28:43 +0000 (+0000)
Subject: eliminated some strcat()'s
X-Git-Tag: SUDO_1_5_0~293
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5fd8419d8edaf9b8c6752d011410726a866ebee5;p=sudo

eliminated some strcat()'s
---

diff --git a/logging.c b/logging.c
index e513f4348..4c5c60994 100644
--- a/logging.c
+++ b/logging.c
@@ -286,13 +286,21 @@ void log_error(code)
     if (code != VALIDATE_ERROR && !(code & GLOBAL_PROBLEM)) {
 
 	/* stuff the command into the logline */
-	/* XXX - this could be sped up */
-	strcat(logline, cmnd);
-	strcat(logline, " ");
+	p = logline + strlen(logline);
+	strcpy(p, cmnd);
+
+	/* add a trailing space */
+	p += strlen(cmnd);
+	*p++ = ' ';
+	*p = '\0';
+
+	/* cat on command args if they exist */
 	if (NewArgc > 1)
 	    for (a = &NewArgv[1]; *a; a++) {
-		strcat(logline, *a);
-		strcat(logline, " ");
+		strcpy(p, *a);
+		p += strlen(*a);
+		*p++ = ' ';
+		*p = '\0';
 	    }
     }