From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Tue, 28 Jul 2015 21:08:20 +0000 (+0200)
Subject: get_remote_group(): eliminate superfluous call to strcspn()
X-Git-Tag: v2.5.2~22^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5f65499fa281748421f2ae65cd794533ada4b4de;p=git

get_remote_group(): eliminate superfluous call to strcspn()

There is no need to call it if value is the empty string. This also
eliminates code duplication.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 680ba66e53..bbc2bb8859 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -976,13 +976,13 @@ static int get_remote_group(const char *key, const char *value, void *priv)
 	if (starts_with(key, "remotes.") &&
 			!strcmp(key + 8, g->name)) {
 		/* split list by white space */
-		size_t wordlen = strcspn(value, " \t\n");
 		while (*value) {
+			size_t wordlen = strcspn(value, " \t\n");
+
 			if (wordlen >= 1)
 				string_list_append(g->list,
 						   xstrndup(value, wordlen));
 			value += wordlen + (value[wordlen] != '\0');
-			wordlen = strcspn(value, " \t\n");
 		}
 	}