From: Tim Peters <tim.peters@gmail.com>
Date: Thu, 2 Mar 2006 20:48:25 +0000 (+0000)
Subject: New XXX pointing out errors in the description of
X-Git-Tag: v2.5a0~394
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5f4390fb0943c0e8ce857ff91e11b5c19b52b506;p=python

New XXX pointing out errors in the description of
PyArena_New(); unsure what the intent is.
---

diff --git a/Include/pyarena.h b/Include/pyarena.h
index 570fceab0e..16365563ad 100644
--- a/Include/pyarena.h
+++ b/Include/pyarena.h
@@ -17,6 +17,12 @@ extern "C" {
 
      PyArena_New() returns an arena pointer.  On error, it
      returns a negative number and sets an exception.
+     XXX (tim):  Not true.  On error, PyArena_New() actually returns NULL,
+     XXX and looks like it may or may not set an exception (e.g., if the
+     XXX internal PyList_New(0) returns NULL, PyArena_New() passes that on
+     XXX and an exception is set; OTOH, if the internal
+     XXX block_new(DEFAULT_BLOCK_SIZE) returns NULL, that's passed on but
+     XXX an exception is not set in that case).
   */
   PyAPI_FUNC(PyArena *) PyArena_New(void);
   PyAPI_FUNC(void) PyArena_Free(PyArena *);