From: Todd C. Miller <Todd.Miller@sudo.ws>
Date: Mon, 29 Jan 2018 21:02:21 +0000 (-0700)
Subject: Check the return value of sudoers_debug_register().
X-Git-Tag: SUDO_1_8_23^2~162
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5e9e641b3d2a93c213747e05bc9a4c1f7bd822f0;p=sudo

Check the return value of sudoers_debug_register().
Coverity CID 182574
---

diff --git a/plugins/sudoers/testsudoers.c b/plugins/sudoers/testsudoers.c
index 31b02a252..4982a501d 100644
--- a/plugins/sudoers/testsudoers.c
+++ b/plugins/sudoers/testsudoers.c
@@ -115,7 +115,7 @@ main(int argc, char *argv[])
     char *p, *grfile, *pwfile;
     const char *errstr;
     int match, host_match, runas_match, cmnd_match;
-    int ch, dflag, exitcode = 0;
+    int ch, dflag, exitcode = EXIT_FAILURE;
     debug_decl(main, SUDOERS_DEBUG_MAIN)
 
 #if defined(SUDO_DEVEL) && defined(__OpenBSD__)
@@ -135,8 +135,9 @@ main(int argc, char *argv[])
 
     /* Initialize the debug subsystem. */
     if (sudo_conf_read(NULL, SUDO_CONF_DEBUG) == -1)
-	exit(EXIT_FAILURE);
-    sudoers_debug_register(getprogname(), sudo_conf_debug_files(getprogname()));
+	goto done;
+    if (!sudoers_debug_register(getprogname(), sudo_conf_debug_files(getprogname())))
+	goto done;
 
     dflag = 0;
     grfile = pwfile = NULL;