From: Rafael Espindola Date: Sat, 4 Apr 2015 19:32:41 +0000 (+0000) Subject: Revert "Revert "Revert "Don't use unique section names by default if using the integr... X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5e1318d69b93e4dfb73e07b55f604de543bb02df;p=clang Revert "Revert "Revert "Don't use unique section names by default if using the integrated as.""" This reverts commit r234101. I will debug what went wrong with ARM. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@234104 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 7b661a7c88..6f8751d5ca 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -3104,10 +3104,8 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.hasArg(options::OPT_dA)) CmdArgs.push_back("-masm-verbose"); - bool UsingIntegratedAssembler = - Args.hasFlag(options::OPT_fintegrated_as, options::OPT_fno_integrated_as, - IsIntegratedAssemblerDefault); - if (!UsingIntegratedAssembler) + if (!Args.hasFlag(options::OPT_fintegrated_as, options::OPT_fno_integrated_as, + IsIntegratedAssemblerDefault)) CmdArgs.push_back("-no-integrated-as"); if (Args.hasArg(options::OPT_fdebug_pass_structure)) { @@ -3351,8 +3349,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, } if (!Args.hasFlag(options::OPT_funique_section_names, - options::OPT_fno_unique_section_names, - !UsingIntegratedAssembler)) + options::OPT_fno_unique_section_names, true)) CmdArgs.push_back("-fno-unique-section-names"); Args.AddAllArgs(CmdArgs, options::OPT_finstrument_functions); diff --git a/test/Driver/function-sections.c b/test/Driver/function-sections.c index 6c243195f6..ba065b1367 100644 --- a/test/Driver/function-sections.c +++ b/test/Driver/function-sections.c @@ -72,13 +72,3 @@ // RUN: -target i386-unknown-linux \ // RUN: -fno-unique-section-names \ // RUN: | FileCheck --check-prefix=CHECK-NOUS %s - -// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \ -// RUN: -target i386-unknown-linux \ -// RUN: -fno-integrated-as \ -// RUN: | FileCheck --check-prefix=CHECK-US %s - -// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \ -// RUN: -target i386-unknown-linux \ -// RUN: -fintegrated-as \ -// RUN: | FileCheck --check-prefix=CHECK-NOUS %s