From: Christian Heimes <christian@cheimes.de>
Date: Sat, 20 Jul 2013 20:42:06 +0000 (+0200)
Subject: Check return value of flush_character_buffer()
X-Git-Tag: v3.4.0a1~127
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5df8ff01d914d1757990438ca6c518d0b1497e96;p=python

Check return value of flush_character_buffer()
CID 486663
---

5df8ff01d914d1757990438ca6c518d0b1497e96
diff --cc Modules/pyexpat.c
index 82d9d6a916,07b1348d37..87cec92041
--- a/Modules/pyexpat.c
+++ b/Modules/pyexpat.c
@@@ -1521,12 -1503,14 +1521,14 @@@ xmlparse_setattro(xmlparseobject *self
        if (self->buffer != NULL) {
          /* there is already a buffer */
          if (self->buffer_used != 0) {
-           flush_character_buffer(self);
+             if (flush_character_buffer(self) < 0) {
+                 return -1;
+             }
          }
          /* free existing buffer */
 -        free(self->buffer);
 +        PyMem_Free(self->buffer);
        }
 -      self->buffer = malloc(new_buffer_size);
 +      self->buffer = PyMem_Malloc(new_buffer_size);
        if (self->buffer == NULL) {
          PyErr_NoMemory();
          return -1;