From: Dean Luick <dean@nethack.org>
Date: Sun, 17 Jan 2021 18:52:30 +0000 (-0600)
Subject: Remove left-over valid file checking
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5dc5ece4122d3d74789f51ed9cf37b8ce313152d;p=nethack

Remove left-over valid file checking

Commit 7054e06e42 ("NetHack minor release checklist items - savefiles")
consolidated valid file checking into the function viable_nhfile().  This
commit removes unused variables left over from that change.
---

diff --git a/src/files.c b/src/files.c
index 25978d00a..ca15fc1b9 100644
--- a/src/files.c
+++ b/src/files.c
@@ -840,7 +840,6 @@ d_level *lev;
 char **bonesid;
 {
     const char *fq_bones;
-    int failed = 0;
     NHFILE *nhfp = (NHFILE *) 0;
 
     *bonesid = set_bonesfile_name(g.bones, lev);
@@ -859,8 +858,6 @@ char **bonesid;
 #else
             nhfp->fd = open(fq_bones, O_RDONLY | O_BINARY, 0);
 #endif
-            if (nhfp->fd < 0)
-                failed = errno;
         }
     }
     nhfp = viable_nhfile(nhfp);
@@ -1043,7 +1040,6 @@ set_error_savefile()
 NHFILE *
 create_savefile()
 {
-    int failed = 0;
     const char *fq_save;
     NHFILE *nhfp = (NHFILE *) 0;
     boolean do_historical = TRUE;
@@ -1076,8 +1072,6 @@ create_savefile()
             nhfp->fd = creat(fq_save, FCMASK);
 #endif
 #endif /* MICRO || WIN32 */
-            if (nhfp->fd < 0)
-                failed = errno;
         }
     }
 #if defined(VMS) && !defined(SECURE)
@@ -1099,7 +1093,6 @@ create_savefile()
 NHFILE *
 open_savefile()
 {
-    int failed = 0;
     const char *fq_save;
     NHFILE *nhfp = (NHFILE *) 0;
     boolean do_historical = TRUE;
@@ -1128,8 +1121,6 @@ open_savefile()
 #else
             nhfp->fd = open(fq_save, O_RDONLY | O_BINARY, 0);
 #endif
-            if (nhfp->fd < 0)
-                failed = errno;
         }
     }
     nhfp = viable_nhfile(nhfp);