From: Vedant Kumar <vsk@apple.com>
Date: Thu, 15 Sep 2016 04:41:37 +0000 (+0000)
Subject: [llvm-cov] Fix tests that aren't checking anything (NFC)
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5d978087009acc69415a5669cbd1d73dd81cd38d;p=llvm

[llvm-cov] Fix tests that aren't checking anything (NFC)

E.g the 'showProjectSummary' test contains some checks which can't fail
because they match themselves...

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@281578 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/test/tools/llvm-cov/Inputs/showProjectSummary.test b/test/tools/llvm-cov/Inputs/showProjectSummary.test
new file mode 100644
index 00000000000..ca9d6ca5ec6
--- /dev/null
+++ b/test/tools/llvm-cov/Inputs/showProjectSummary.test
@@ -0,0 +1,16 @@
+TEXT-TITLE: Test Suite
+TEXT: Coverage Report
+TEXT: Created:
+TEXT-FILE-NOT: (Binary: showProjectSummary.covmapping)
+TEXT-FUNCTION: main:
+TEXT-FOOTER: Generated by llvm-cov
+
+HTML-TITLE: <h1>Test Suite</h1>
+HTML: <h2>Coverage Report</h2>
+HTML: <h4>Created:{{.*}}</h4>
+HTML-FILE: <pre>{{.*}}showProjectSummary.cpp (Binary: showProjectSummary.covmapping)</pre>
+HTML-FUNCTION: <pre>main</pre>
+HTML-HEADER: <td><pre>Line No.</pre></td>
+HTML-HEADER: <td><pre>Count</pre></td>
+HTML-HEADER: <td><pre>Source (<a href='#L8'>jump to first uncovered line</a>)</pre></td>
+HTML-FOOTER: <h5>Generated by llvm-cov{{.*}}</h5>
diff --git a/test/tools/llvm-cov/native_separators.c b/test/tools/llvm-cov/native_separators.c
index 4708738b7ea..3db888689c4 100644
--- a/test/tools/llvm-cov/native_separators.c
+++ b/test/tools/llvm-cov/native_separators.c
@@ -18,7 +18,3 @@
 // HTML: <pre>\tmp\native_separators.c (Binary: native_separators.covmapping)</pre>
 
 int main() {}
-
-// RUN: llvm-cov show %S/Inputs/native_separators.covmapping -instr-profile=%t.profdata -filename-equivalence %s -o %t.dir
-// RUN: FileCheck -check-prefixes=TEXT -input-file=%t.dir/coverage/tmp/native_separators.c.txt %s
-// TEXT: \tmp\native_separators.c (Binary: native_separators.covmapping)
diff --git a/test/tools/llvm-cov/showProjectSummary.cpp b/test/tools/llvm-cov/showProjectSummary.cpp
index dfe59bfbedc..604c7730cc7 100644
--- a/test/tools/llvm-cov/showProjectSummary.cpp
+++ b/test/tools/llvm-cov/showProjectSummary.cpp
@@ -12,33 +12,17 @@ int main(int argc, char ** argv) {
 }
 
 // Test console output.
-// RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile %t.profdata -filename-equivalence %s | FileCheck -check-prefixes=TEXT,TEXT-FILE,TEXT-HEADER %s
-// RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile %t.profdata -project-title "Test Suite" -filename-equivalence %s | FileCheck -check-prefixes=TEXT-TITLE,TEXT,TEXT-FILE,TEXT-HEADER %s
-// RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile %t.profdata -project-title "Test Suite" -name=main -filename-equivalence %s | FileCheck -check-prefixes=TEXT-FUNCTION,TEXT-HEADER %s
+// RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile %t.profdata -filename-equivalence %s | FileCheck -check-prefixes=TEXT,TEXT-FILE,TEXT-HEADER %S/Inputs/showProjectSummary.test
+// RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile %t.profdata -project-title "Test Suite" -filename-equivalence %s | FileCheck -check-prefixes=TEXT-TITLE,TEXT,TEXT-FILE,TEXT-HEADER %S/Inputs/showProjectSummary.test
+// RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile %t.profdata -project-title "Test Suite" -name=main -filename-equivalence %s | FileCheck -check-prefixes=TEXT-FUNCTION,TEXT-HEADER %S/Inputs/showProjectSummary.test
 // RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -instr-profile=%t.profdata -o %t.dir -filename-equivalence %s
-// RUN: FileCheck -check-prefixes=TEXT-FOOTER -input-file=%t.dir/index.txt %s
-// TEXT-TITLE: Test Suite
-// TEXT: Coverage Report
-// TEXT: Created:
-// TEXT-FILE: showProjectSummary.cpp:
-// TEXT-FILE: showProjectSummary.covmapping:
-// TEXT-FUNCTION: main:
-// TEXT-FOOTER: Generated by llvm-cov
+// RUN: FileCheck -check-prefixes=TEXT-FOOTER -input-file=%t.dir/index.txt %S/Inputs/showProjectSummary.test
 
 // Test html output.
 // RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -format=html -o %t.dir -instr-profile %t.profdata -filename-equivalence %s
-// RUN: FileCheck -check-prefixes=HTML,HTML-FILE,HTML-HEADER -input-file %t.dir/coverage/tmp/showProjectSummary.cpp.html %s
+// RUN: FileCheck -check-prefixes=HTML,HTML-FILE,HTML-HEADER -input-file %t.dir/coverage/tmp/showProjectSummary.cpp.html %S/Inputs/showProjectSummary.test
 // RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -format=html -o %t.dir -instr-profile %t.profdata -project-title "Test Suite" -filename-equivalence %s
-// RUN: FileCheck -check-prefixes=HTML-TITLE,HTML,HTML-FILE,HTML-HEADER -input-file %t.dir/coverage/tmp/showProjectSummary.cpp.html %s
-// RUN: FileCheck -check-prefixes=HTML-TITLE,HTML,HTML-FOOTER -input-file %t.dir/index.html %s
+// RUN: FileCheck -check-prefixes=HTML-TITLE,HTML,HTML-FILE,HTML-HEADER -input-file %t.dir/coverage/tmp/showProjectSummary.cpp.html %S/Inputs/showProjectSummary.test
+// RUN: FileCheck -check-prefixes=HTML-TITLE,HTML,HTML-FOOTER -input-file %t.dir/index.html %S/Inputs/showProjectSummary.test
 // RUN: llvm-cov show %S/Inputs/showProjectSummary.covmapping -format=html -o %t.dir -instr-profile %t.profdata  -project-title "Test Suite" -filename-equivalence -name=main %s
-// RUN: FileCheck -check-prefixes=HTML-FUNCTION,HTML-HEADER -input-file %t.dir/functions.html %s
-// HTML-TITLE: <h1>Test Suite</h1>
-// HTML: <h2>Coverage Report</h2>
-// HTML: <h4>Created:{{.*}}</h4>
-// HTML-FILE: <pre>{{.*}}showProjectSummary.cpp (Binary: showProjectSummary.covmapping)</pre>
-// HTML-FUNCTION: <pre>main</pre>
-// HTML-HEADER: <td><pre>Line No.</pre></td>
-// HTML-HEADER: <td><pre>Count</pre></td>
-// HTML-HEADER: <td><pre>Source (<a href='#L8'>jump to first uncovered line</a>)</pre></td>
-// HTML-FOOTER: <h5>Generated by llvm-cov{{.*}}</h5>
+// RUN: FileCheck -check-prefixes=HTML-FUNCTION,HTML-HEADER -input-file %t.dir/functions.html %S/Inputs/showProjectSummary.test