From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 25 Mar 2010 15:50:10 +0000 (+0000)
Subject: Fix ginint4_queryextract() to actually do what it was intended to do for an
X-Git-Tag: REL9_0_ALPHA5~28
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5ceb13c8a12320a44fa211cf0ba32b1641270aeb;p=postgresql

Fix ginint4_queryextract() to actually do what it was intended to do for an
unsatisfiable query, such as indexcol && empty_array.  It should return -1
to tell GIN no scan is required; but silly typo disabled the logic for that,
resulting in unnecessary "GIN indexes do not support whole-index scans" error.
Per bug report from Jeff Trout.

Back-patch to 8.3 where the logic was introduced.
---

diff --git a/contrib/intarray/_int_gin.c b/contrib/intarray/_int_gin.c
index 2bf8fc54bb..375ff3ae25 100644
--- a/contrib/intarray/_int_gin.c
+++ b/contrib/intarray/_int_gin.c
@@ -1,5 +1,5 @@
 /*
- * $PostgreSQL: pgsql/contrib/intarray/_int_gin.c,v 1.10 2009/06/11 14:48:51 momjian Exp $
+ * $PostgreSQL: pgsql/contrib/intarray/_int_gin.c,v 1.11 2010/03/25 15:50:10 tgl Exp $
  */
 #include "postgres.h"
 
@@ -65,7 +65,7 @@ ginint4_queryextract(PG_FUNCTION_ARGS)
 		}
 	}
 
-	if (nentries == 0)
+	if (*nentries == 0)
 	{
 		switch (strategy)
 		{