From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 7 Oct 2019 14:32:13 +0000 (+0200)
Subject: dnsdist: Clear the DoH Session Ticket Encryption Key in the ctor
X-Git-Tag: dnsdist-1.4.0-rc4~37^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5cbb271a9028cde80c4a03980f2efb4997a47de8;p=pdns

dnsdist: Clear the DoH Session Ticket Encryption Key in the ctor
---

diff --git a/pdns/doh.hh b/pdns/doh.hh
index 41e600329..6b5503620 100644
--- a/pdns/doh.hh
+++ b/pdns/doh.hh
@@ -40,6 +40,11 @@ private:
 
 struct DOHFrontend
 {
+  DOHFrontend()
+  {
+    d_rotatingTicketsKey.clear();
+  }
+
   std::shared_ptr<DOHServerConfig> d_dsc{nullptr};
   std::vector<std::pair<std::string, std::string>> d_certKeyPairs;
   std::vector<std::string> d_ocspFiles;
@@ -58,9 +63,7 @@ struct DOHFrontend
   std::vector<std::string> d_urls;
   std::string d_ticketKeyFile;
 
-  std::atomic_flag d_rotatingTicketsKey;
   time_t d_ticketsKeyRotationDelay{43200};
-  time_t d_ticketsKeyNextRotation{0};
   size_t d_maxStoredSessions{20480};
   uint8_t d_numberOfTicketsKeys{5};
   bool d_enableTickets{true};
@@ -124,6 +127,10 @@ struct DOHFrontend
   void handleTicketsKeyRotation();
 
 #endif /* HAVE_DNS_OVER_HTTPS */
+
+private:
+  time_t d_ticketsKeyNextRotation{0};
+  std::atomic_flag d_rotatingTicketsKey;
 };
 
 #ifndef HAVE_DNS_OVER_HTTPS