From: Robert Haas <rhaas@postgresql.org>
Date: Wed, 26 Jan 2011 11:42:51 +0000 (-0500)
Subject: Add a comment explaining why we force physical removal of OIDs.
X-Git-Tag: REL9_1_ALPHA4~355
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5c2a7c6e97741564ab4ff336eac8d8227485dd4c;p=postgresql

Add a comment explaining why we force physical removal of OIDs.

Noah Misch, slightly revised.
---

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 8a281968ad..8fa9d7fa7f 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -4942,7 +4942,9 @@ ATExecDropColumn(List **wqueue, Relation rel, const char *colName,
 
 	/*
 	 * If we dropped the OID column, must adjust pg_class.relhasoids and tell
-	 * Phase 3 to physically get rid of the column.
+	 * Phase 3 to physically get rid of the column.  We formerly left the
+	 * column in place physically, but this caused subtle problems.  See
+	 * http://archives.postgresql.org/pgsql-hackers/2009-02/msg00363.php
 	 */
 	if (attnum == ObjectIdAttributeNumber)
 	{