From: Ted Kremenek <kremenek@apple.com>
Date: Sat, 25 Oct 2008 20:09:21 +0000 (+0000)
Subject: Do not crash when performing VisitLValue on union types.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5b2316a8b695589f8e91baf1df06c1082ac94b6d;p=clang

Do not crash when performing VisitLValue on union types.
This fixes PR 2948.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@58148 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/GRExprEngine.cpp b/lib/Analysis/GRExprEngine.cpp
index 7d60dec9b8..2a74311cd9 100644
--- a/lib/Analysis/GRExprEngine.cpp
+++ b/lib/Analysis/GRExprEngine.cpp
@@ -457,9 +457,10 @@ void GRExprEngine::VisitLValue(Expr* Ex, NodeTy* Pred, NodeSet& Dst) {
       // can be used in a lvalue context.  We need to enhance our support
       // of such temporaries in both the environment and the store, so right
       // now we just do a regular visit.
-      assert (Ex->getType()->isAggregateType() && 
-              "Other kinds of expressions with non-aggregate types do not "
-              "have lvalues.");
+      assert ((Ex->getType()->isAggregateType() || 
+              Ex->getType()->isUnionType()) &&
+              "Other kinds of expressions with non-aggregate/union types do"
+              " not have lvalues.");
       
       Visit(Ex, Pred, Dst);
   }
diff --git a/test/Analysis/misc-ps.m b/test/Analysis/misc-ps.m
index f473f290c7..0340c027cd 100644
--- a/test/Analysis/misc-ps.m
+++ b/test/Analysis/misc-ps.m
@@ -43,3 +43,16 @@ void divzeroassumeB(unsigned x, unsigned j) {
   if (j == 0) x = x / 0;  // no-warning
 }
 
+// PR 2948 (testcase; crash on VisitLValue for union types)
+// http://llvm.org/bugs/show_bug.cgi?id=2948
+
+void checkaccess_union() {
+  int ret = 0, status;
+  if (((((__extension__ (((union {
+    __typeof (status) __in; int __i;}
+    )
+    {
+      .__in = (status)}
+      ).__i))) & 0xff00) >> 8) == 1)
+        ret = 1;
+}