From: Teodor Sigaev <teodor@sigaev.ru>
Date: Tue, 10 Apr 2018 11:59:27 +0000 (+0300)
Subject: Remove wrongly backpatched piece of code in cube.c
X-Git-Tag: REL9_6_9~36
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5b0fa06f65e959f73c145c8104cb3fa8505fca73;p=postgresql

Remove wrongly backpatched piece of code in cube.c

Due to sloppy division of changes between f50c80dbb (which was not
back-patched) and 563a053bd, this piece of code was wrongly backpatched to
REL_10_STABLE and REL9_6_STABLE.  This code never causes real error because
its condition is never satisfied, but it's a dead code, which needs to be
removed.

Alexander Korotkov per gripe from Tom Lane
---

diff --git a/contrib/cube/cube.c b/contrib/cube/cube.c
index 6c4a5b24c1..d835fe1f87 100644
--- a/contrib/cube/cube.c
+++ b/contrib/cube/cube.c
@@ -1587,7 +1587,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)
 {
 	NDBOX	   *cube = PG_GETARG_NDBOX(0);
 	int			coord = PG_GETARG_INT32(1);
-	bool		inverse = false;
 	float8		result;
 
 	/* 0 is the only unsupported coordinate value */
@@ -1625,10 +1624,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)
 		result = 0.0;
 	}
 
-	/* Inverse value if needed */
-	if (inverse)
-		result = -result;
-
 	PG_RETURN_FLOAT8(result);
 }