From: Sandro Santilli <strk@keybit.net>
Date: Thu, 23 Feb 2012 16:07:05 +0000 (+0000)
Subject: Don't deep clone POINTARRAY in GML input routine.
X-Git-Tag: 2.0.0beta1~77
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=59cf05272549cde0145585e35aec4c34e09c193c;p=postgis

Don't deep clone POINTARRAY in GML input routine.

Let's see if doing so exposes more memory errors (#1591).
Does run valgrind clean here.

git-svn-id: http://svn.osgeo.org/postgis/trunk@9279 b70326c6-7e19-0410-871a-916f4a2858ee
---

diff --git a/postgis/lwgeom_in_gml.c b/postgis/lwgeom_in_gml.c
index 0d8ce77e1..1a045b6e7 100644
--- a/postgis/lwgeom_in_gml.c
+++ b/postgis/lwgeom_in_gml.c
@@ -618,9 +618,7 @@ static POINTARRAY* parse_gml_coordinates(xmlNodePtr xnode, bool *hasz)
 
 	xmlFree(gml_coord);
 
-	/* TODO: this makes no sense, we shouldn't have to clone. but we're seeing 
-	   memory problems when we don't. */
-	return ptarray_clone_deep(dpa);
+	return dpa; /* ptarray_clone_deep(dpa); */
 }