From: George Karpenkov <ekarpenkov@apple.com>
Date: Wed, 31 Oct 2018 17:38:12 +0000 (+0000)
Subject: [analyzer] Enable retain count checking for OSObject by defa
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=597ac06e9d4ee7609bd9b70640774845b11b4130;p=clang

[analyzer] Enable retain count checking for OSObject by defa

The FP rate seems to be good enough now.

Differential Revision: https://reviews.llvm.org/D53849

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@345745 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h b/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h
index e768414261..388c2eaaf0 100644
--- a/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h
+++ b/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h
@@ -282,7 +282,7 @@ public:
   ~RetainCountChecker() override { DeleteContainerSeconds(DeadSymbolTags); }
 
   bool shouldCheckOSObjectRetainCount() const {
-    return Options.getBooleanOption("CheckOSObject", false, this);
+    return Options.getBooleanOption("CheckOSObject", true, this);
   }
 
   void checkEndAnalysis(ExplodedGraph &G, BugReporter &BR,
diff --git a/test/Analysis/osobject-retain-release.cpp b/test/Analysis/osobject-retain-release.cpp
index 17360ac322..1159eaed0d 100644
--- a/test/Analysis/osobject-retain-release.cpp
+++ b/test/Analysis/osobject-retain-release.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_analyze_cc1 -analyze -analyzer-checker=core,osx.cocoa.RetainCount -analyzer-config osx.cocoa.RetainCount:CheckOSObject=true -analyzer-output=text -verify %s
+// RUN: %clang_analyze_cc1 -analyze -analyzer-checker=core,osx.cocoa.RetainCount -analyzer-output=text -verify %s
 
 struct OSMetaClass;