From: Lysandros Nikolaou <lisandrosnik@gmail.com>
Date: Sun, 4 Nov 2018 21:21:28 +0000 (+0100)
Subject: bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318)
X-Git-Tag: v3.8.0a1~584
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=59668aa8b7f174b59304eab833c1c1181886c3c6;p=python

bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318)
---

diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
index 0f950b2325..711fb69ebd 100644
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -5,6 +5,7 @@
 
 import locale
 import os
+import platform
 import re
 import subprocess
 import sys
@@ -48,6 +49,10 @@ if gdb_major_version < 7:
 if not sysconfig.is_python_build():
     raise unittest.SkipTest("test_gdb only works on source builds at the moment.")
 
+if 'Clang' in platform.python_compiler() and sys.platform == 'darwin':
+    raise unittest.SkipTest("test_gdb doesn't work correctly when python is"
+                            " built with LLVM clang")
+
 # Location of custom hooks file in a repository checkout.
 checkout_hook_path = os.path.join(os.path.dirname(sys.executable),
                                   'python-gdb.py')
diff --git a/Misc/ACKS b/Misc/ACKS
index 08ff6d11fd..89fb0c7000 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1147,6 +1147,7 @@ Samuel Nicolary
 Jonathan Niehof
 Gustavo Niemeyer
 Oscar Nierstrasz
+Lysandros Nikolaou
 Hrvoje Nikšić
 Gregory Nofi
 Jesse Noller
diff --git a/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst
new file mode 100644
index 0000000000..9c6b4ef907
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst
@@ -0,0 +1,4 @@
+After several reports that test_gdb does not work properly on macOS and
+since gdb is not shipped by default anymore, test_gdb is now skipped on
+macOS when LLVM Clang has been used to compile Python. Patch by
+Lysandros Nikolaou