From: Antoine Pitrou <solipsis@pitrou.net>
Date: Sun, 31 Oct 2010 13:05:48 +0000 (+0000)
Subject: Merged revisions 85982 via svnmerge from
X-Git-Tag: v2.7.1rc1~89
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=594a046b88abf26c2c2a314ca5b54e4c808ba801;p=python

Merged revisions 85982 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r85982 | antoine.pitrou | 2010-10-30 18:19:14 +0200 (sam., 30 oct. 2010) | 4 lines

  Issue #10253: FileIO leaks a file descriptor when trying to open a file
  for append that isn't seekable.  Patch by Brian Brazil.
........
---

diff --git a/Lib/test/test_fileio.py b/Lib/test/test_fileio.py
index cb6ec8e020..a63ba06bb4 100644
--- a/Lib/test/test_fileio.py
+++ b/Lib/test/test_fileio.py
@@ -341,6 +341,7 @@ class OtherFileTests(unittest.TestCase):
         f.truncate(15)
         self.assertEqual(f.tell(), 5)
         self.assertEqual(f.seek(0, os.SEEK_END), 15)
+        f.close()
 
     def testTruncateOnWindows(self):
         def bug801631():
diff --git a/Misc/NEWS b/Misc/NEWS
index dc5dca453f..82c0f513a1 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -66,6 +66,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #10253: FileIO leaks a file descriptor when trying to open a file
+  for append that isn't seekable.  Patch by Brian Brazil.
+
 - Issue #6105: json.dumps now respects OrderedDict's iteration order.
 
 - Issue #9295: Fix a crash under Windows when calling close() on a file
diff --git a/Modules/_io/fileio.c b/Modules/_io/fileio.c
index a2a5f737f7..a685b134a3 100644
--- a/Modules/_io/fileio.c
+++ b/Modules/_io/fileio.c
@@ -367,8 +367,13 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
            end of file (otherwise, it might be done only on the
            first write()). */
         PyObject *pos = portable_lseek(self->fd, NULL, 2);
-        if (pos == NULL)
+        if (pos == NULL) {
+            if (closefd) {
+                close(self->fd);
+                self->fd = -1;
+            }
             goto error;
+        }
         Py_DECREF(pos);
     }