From: Máté Kocsis <kocsismate@woohoolabs.com>
Date: Fri, 10 Apr 2020 15:06:15 +0000 (+0200)
Subject: Fix the default parameter values of session_set_save_handler()
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5868aced2e37d243b09d888507a08f85604d9859;p=php

Fix the default parameter values of session_set_save_handler()

Co-Authored-By: Christoph M. Becker <cmbecker69@gmx.de>
---

diff --git a/ext/session/session.stub.php b/ext/session/session.stub.php
index 09c35aae28..1363b2aef4 100644
--- a/ext/session/session.stub.php
+++ b/ext/session/session.stub.php
@@ -37,7 +37,7 @@ function session_register_shutdown(): void {}
 /** @alias session_write_close */
 function session_commit(): bool {}
 
-function session_set_save_handler($open, $close = null, $read = null, $write = null, $destroy = null, $gc = null, $create_sid = null, $validate_sid = null, $update_timestamp = null): bool {}
+function session_set_save_handler($open, $close = UNKNOWN, $read = UNKNOWN, $write = UNKNOWN, $destroy = UNKNOWN, $gc = UNKNOWN, $create_sid = UNKNOWN, $validate_sid = UNKNOWN, $update_timestamp = UNKNOWN): bool {}
 
 function session_cache_limiter(string $cache_limiter = UNKNOWN): string|false {}
 
diff --git a/ext/session/session_arginfo.h b/ext/session/session_arginfo.h
index f8814376d6..c4762eb25b 100644
--- a/ext/session/session_arginfo.h
+++ b/ext/session/session_arginfo.h
@@ -58,14 +58,14 @@ ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_session_set_save_handler, 0, 1, _IS_BOOL, 0)
 	ZEND_ARG_INFO(0, open)
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, close, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, read, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, write, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, destroy, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, gc, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, create_sid, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, validate_sid, "null")
-	ZEND_ARG_INFO_WITH_DEFAULT_VALUE(0, update_timestamp, "null")
+	ZEND_ARG_INFO(0, close)
+	ZEND_ARG_INFO(0, read)
+	ZEND_ARG_INFO(0, write)
+	ZEND_ARG_INFO(0, destroy)
+	ZEND_ARG_INFO(0, gc)
+	ZEND_ARG_INFO(0, create_sid)
+	ZEND_ARG_INFO(0, validate_sid)
+	ZEND_ARG_INFO(0, update_timestamp)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_session_cache_limiter, 0, 0, MAY_BE_STRING|MAY_BE_FALSE)