From: Ilya Biryukov <ibiryukov@google.com>
Date: Thu, 13 Dec 2018 17:23:48 +0000 (+0000)
Subject: [CodeComplete] Temporarily disable failing assertion
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=585dd0bb3b615cfa42626a400ba5f45df96e661a;p=clang

[CodeComplete] Temporarily disable failing assertion

Found the case in the clang codebase where the assertion fires.
To avoid crashing assertion-enabled builds before I re-add the missing
operation.
Will restore the assertion alongside the upcoming fix.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@349061 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaCodeComplete.cpp b/lib/Sema/SemaCodeComplete.cpp
index 645830b488..773dd46ac4 100644
--- a/lib/Sema/SemaCodeComplete.cpp
+++ b/lib/Sema/SemaCodeComplete.cpp
@@ -4949,7 +4949,8 @@ static QualType getPreferredTypeOfBinaryRHS(Sema &S, Expr *LHS,
   case tok::arrowstar:
     return QualType();
   default:
-    assert(false && "unhandled binary op");
+    // FIXME(ibiryukov): handle the missing op, re-add the assertion.
+    // assert(false && "unhandled binary op");
     return QualType();
   }
 }