From: Richard Smith <richard-llvm@metafoo.co.uk>
Date: Wed, 27 Aug 2014 18:56:18 +0000 (+0000)
Subject: Fix regression in r216520: don't apply nonnull to non-pointer function
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=585339c03e697256463ffd118341423626181524;p=clang

Fix regression in r216520: don't apply nonnull to non-pointer function
parameters in the IR.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@216574 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/CodeGen/CGCall.cpp b/lib/CodeGen/CGCall.cpp
index 45a6259089..c95680ccda 100644
--- a/lib/CodeGen/CGCall.cpp
+++ b/lib/CodeGen/CGCall.cpp
@@ -1557,8 +1557,17 @@ void CodeGenFunction::EmitFunctionProlog(const CGFunctionInfo &FI,
         llvm::Value *V = AI;
 
         if (const ParmVarDecl *PVD = dyn_cast<ParmVarDecl>(Arg)) {
-          if ((NNAtt && NNAtt->isNonNull(PVD->getFunctionScopeIndex())) ||
-              PVD->hasAttr<NonNullAttr>())
+          // FIXME: __attribute__((nonnull)) can also be applied to:
+          //   - references to pointers, where the pointee is known to be
+          //     nonnull (apparently a Clang extension)
+          //   - transparent unions containing pointers
+          // In the former case, LLVM IR cannot represent the constraint. In
+          // the latter case, we have no guarantee that the transparent union
+          // is in fact passed as a pointer.
+          if (((NNAtt && NNAtt->isNonNull(PVD->getFunctionScopeIndex())) ||
+               PVD->hasAttr<NonNullAttr>()) &&
+              (PVD->getType()->isAnyPointerType() ||
+               PVD->getType()->isBlockPointerType()))
             AI->addAttr(llvm::AttributeSet::get(getLLVMContext(),
                                                 AI->getArgNo() + 1,
                                                 llvm::Attribute::NonNull));
diff --git a/test/CodeGen/nonnull.c b/test/CodeGen/nonnull.c
index 4d6cc4568d..e234105d9a 100644
--- a/test/CodeGen/nonnull.c
+++ b/test/CodeGen/nonnull.c
@@ -21,3 +21,23 @@ int * bar3() __attribute__((returns_nonnull))  {
   return &a;
 }
 
+// CHECK: define i32 @bar4(i32 %n, i32* nonnull %p)
+int bar4(int n, int *p) __attribute__((nonnull)) {
+  return n + *p;
+}
+
+// CHECK: define i32 @bar5(i32 %n, i32* nonnull %p)
+int bar5(int n, int *p) __attribute__((nonnull(1, 2))) {
+  return n + *p;
+}
+
+typedef union {
+  unsigned long long n;
+  int *p;
+  double d;
+} TransparentUnion __attribute__((transparent_union));
+
+// CHECK: define i32 @bar6(i64 %
+int bar6(TransparentUnion tu) __attribute__((nonnull(1))) {
+  return *tu.p;
+}