From: Nikita Popov <nikita.ppv@gmail.com>
Date: Wed, 4 Nov 2020 11:30:41 +0000 (+0100)
Subject: Don't xfail method_static_var.phpt
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=57b0e5a0455e621bec7acfbf57fb3da8776d1465;p=php

Don't xfail method_static_var.phpt

Let's test the current behavior here. It might not be right, but
it's long-standing behavior.

Nearly missed an assertion failure here because the test was
XFAILed...
---

diff --git a/Zend/tests/method_static_var.phpt b/Zend/tests/method_static_var.phpt
index b419647517..06574732d7 100644
--- a/Zend/tests/method_static_var.phpt
+++ b/Zend/tests/method_static_var.phpt
@@ -1,31 +1,26 @@
 --TEST--
 Initial value of static var in method depends on the include time of the class definition
---XFAIL--
-Maybe not a bug
 --FILE--
 <?php
+
+/* The current behavior is probably a bug, but we should still test how it currently works. */
+
 class Foo {
- public function __construct() {
-  eval("class Bar extends Foo {}");
- }
- public static function test() {
-  static $i = 0;
-  var_dump(++$i);
- }
+    public static function test() {
+        static $i = 0;
+        var_dump(++$i);
+    }
 }
 
-foo::test();
-new Foo;
-foo::test();
+Foo::test();
+eval("class Bar extends Foo {}");
+Foo::test();
 
-/**
- * function_add_ref() makes a clone of static variables for inherited functions, so $i in Bar::test gets initial value 1
- */
 Bar::test();
 Bar::test();
 ?>
 --EXPECT--
 int(1)
 int(2)
-int(1)
 int(2)
+int(3)