From: Victor Stinner <victor.stinner@gmail.com>
Date: Thu, 3 Sep 2015 14:33:16 +0000 (+0200)
Subject: Don't abuse volatile keyword in pytime.c
X-Git-Tag: v3.6.0a1~1684
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5786aef382b0f64720060d6372c215e939461957;p=python

Don't abuse volatile keyword in pytime.c

Only use it on the most important number. This change fixes also a compiler
warning on modf().
---

diff --git a/Python/pytime.c b/Python/pytime.c
index cea3cf5d43..d226389a7c 100644
--- a/Python/pytime.c
+++ b/Python/pytime.c
@@ -135,8 +135,9 @@ int
 _PyTime_ObjectToTime_t(PyObject *obj, time_t *sec, _PyTime_round_t round)
 {
     if (PyFloat_Check(obj)) {
+        double intpart, err;
         /* volatile avoids optimization changing how numbers are rounded */
-        volatile double d, intpart, err;
+        volatile double d;
 
         d = PyFloat_AsDouble(obj);
         if (round == _PyTime_ROUND_HALF_UP)
@@ -257,8 +258,9 @@ static int
 _PyTime_FromFloatObject(_PyTime_t *t, double value, _PyTime_round_t round,
                         long to_nanoseconds)
 {
+    double err;
     /* volatile avoids optimization changing how numbers are rounded */
-    volatile double d, err;
+    volatile double d;
 
     /* convert to a number of nanoseconds */
     d = value;