From: Antony Dovgal <tony2001@php.net>
Date: Thu, 1 Jun 2006 11:56:23 +0000 (+0000)
Subject: throw a warning when using invalid offset types with strings
X-Git-Tag: BEFORE_NEW_OUTPUT_API~12
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=57566a78b5512f8debba69db2ed68e4f2fa072aa;p=php

throw a warning when using invalid offset types with strings
---

diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c
index e2bd803857..3f56528a8c 100644
--- a/Zend/zend_execute.c
+++ b/Zend/zend_execute.c
@@ -1112,6 +1112,20 @@ static void zend_fetch_dimension_address(temp_variable *result, zval **container
 				}
 
 				if (Z_TYPE_P(dim) != IS_LONG) {
+					switch(Z_TYPE_P(dim)) {
+						/* case IS_LONG: */
+						case IS_STRING:
+						case IS_UNICODE:
+						case IS_DOUBLE:
+						case IS_NULL:
+						case IS_BOOL:
+							/* do nothing */
+							break;
+						default:
+							zend_error(E_WARNING, "Illegal offset type");
+							break;
+					}
+
 					tmp = *dim;
 					zval_copy_ctor(&tmp);
 					convert_to_long(&tmp);