From: Nick Lewycky <nicholas@mxc.ca>
Date: Wed, 4 May 2011 03:44:01 +0000 (+0000)
Subject: No, fix this use after free properly.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=574bb5a5bbc7ffd726981e67e476ca1f8840276c;p=clang

No, fix this use after free properly.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@130833 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp
index f2b685b8b2..3592fc5ead 100644
--- a/lib/Driver/Tools.cpp
+++ b/lib/Driver/Tools.cpp
@@ -643,9 +643,8 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args,
   CmdArgs.push_back("-target-abi");
   CmdArgs.push_back(ABIName);
 
-  std::string MArch;
   if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) {
-    MArch = A->getValue(Args);
+    llvm::StringRef MArch = A->getValue(Args);
     CmdArgs.push_back("-target-cpu");
 
     if ((MArch == "r2000") || (MArch == "r3000"))
@@ -653,7 +652,7 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args,
     else if (MArch == "r6000")
       CmdArgs.push_back("mips2");
     else
-      CmdArgs.push_back(MArch.c_str());
+      CmdArgs.push_back(Args.MakeArgString(MArch));
   }
 
   // Select the float ABI as determined by -msoft-float, -mhard-float, and