From: Felipe Pena <felipe@php.net>
Date: Fri, 21 Nov 2008 22:48:27 +0000 (+0000)
Subject: - MFH: Fixed memory leak in readline_callback_handler_remove()
X-Git-Tag: php-5.2.7RC5~26
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=572b3f83a3123b986cb671ff0babf616e0dd1005;p=php

- MFH: Fixed memory leak in readline_callback_handler_remove()
---

diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 3a481dfa4c..9466fb0cbe 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -516,7 +516,8 @@ PHP_FUNCTION(readline_callback_handler_install)
 
 	if (_prepped_callback) {
 		rl_callback_handler_remove();
-		zval_ptr_dtor(&_prepped_callback);
+		zval_dtor(_prepped_callback);
+		FREE_ZVAL(_prepped_callback);
 	}
 
 	MAKE_STD_ZVAL(_prepped_callback);
@@ -545,6 +546,7 @@ PHP_FUNCTION(readline_callback_handler_remove)
 {
 	if (_prepped_callback) {
 		rl_callback_handler_remove();
+		zval_dtor(_prepped_callback);
 		FREE_ZVAL(_prepped_callback);
 		_prepped_callback = 0;
 		RETURN_TRUE;