From: Robert Haas <rhaas@postgresql.org>
Date: Tue, 21 Jan 2014 15:02:37 +0000 (-0500)
Subject: Avoid a possible relcache leak in get_object_address_attribute.
X-Git-Tag: REL9_4_BETA1~647
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5709b8acc67d80584e9623a1d355374b580c95e8;p=postgresql

Avoid a possible relcache leak in get_object_address_attribute.

There's no apparent way to trigger this, so I'm not going to worry
about back-patching it for now.  But it's still wrong.

Marti Raudsepp
---

diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c
index 991c02abbf..a6ec6aa04b 100644
--- a/src/backend/catalog/objectaddress.c
+++ b/src/backend/catalog/objectaddress.c
@@ -1024,6 +1024,7 @@ get_object_address_attribute(ObjectType objtype, List *objname,
 		address.classId = RelationRelationId;
 		address.objectId = InvalidOid;
 		address.objectSubId = InvalidAttrNumber;
+		relation_close(relation, lockmode);
 		return address;
 	}