From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 18 Dec 2017 13:11:51 +0000 (-0800)
Subject: bpo-32365: Fix a reference leak when compile __debug__. (GH-4916) (#4918)
X-Git-Tag: v3.6.5rc1~194
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5659743b5693c9e23313a74117948294e35013f4;p=python

bpo-32365: Fix a reference leak when compile __debug__. (GH-4916) (#4918)

It was introduced in bpo-27169.
(cherry picked from commit bd6ec4d79e8575df3d08f8a89ba721930032714c)
---

diff --git a/Python/compile.c b/Python/compile.c
index 13b4fb8307..3b8f9bbd44 100644
--- a/Python/compile.c
+++ b/Python/compile.c
@@ -3032,10 +3032,6 @@ compiler_nameop(struct compiler *c, identifier name, expr_context_ty ctx)
     PyObject *mangled;
     /* XXX AugStore isn't used anywhere! */
 
-    mangled = _Py_Mangle(c->u->u_private, name);
-    if (!mangled)
-        return 0;
-
     assert(!_PyUnicode_EqualToASCIIString(name, "None") &&
            !_PyUnicode_EqualToASCIIString(name, "True") &&
            !_PyUnicode_EqualToASCIIString(name, "False"));
@@ -3045,6 +3041,10 @@ compiler_nameop(struct compiler *c, identifier name, expr_context_ty ctx)
         return 1;
     }
 
+    mangled = _Py_Mangle(c->u->u_private, name);
+    if (!mangled)
+        return 0;
+
     op = 0;
     optype = OP_NAME;
     scope = PyST_GetScope(c->u->u_ste, mangled);