From: Richard Smith Date: Thu, 21 Dec 2017 22:26:47 +0000 (+0000) Subject: Suppress "redundant parens" warning for "A (::B())". X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5645be43c2a199fbb08ba2666210e3aa673062a1;p=clang Suppress "redundant parens" warning for "A (::B())". This is a slightly odd construct (it's more common to see "A (::B)()") but can happen in friend declarations, and the parens are not redundant as they prevent the :: binding to the left. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@321318 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaType.cpp b/lib/Sema/SemaType.cpp index b45d31c6b1..63a4963946 100644 --- a/lib/Sema/SemaType.cpp +++ b/lib/Sema/SemaType.cpp @@ -3165,7 +3165,12 @@ static void warnAboutRedundantParens(Sema &S, Declarator &D, QualType T) { // In a new-type-id, function chunks require parentheses. if (D.getContext() == Declarator::CXXNewContext) return; - LLVM_FALLTHROUGH; + // FIXME: "A(f())" deserves a vexing-parse warning, not just a + // redundant-parens warning, but we don't know whether the function + // chunk was syntactically valid as an expression here. + CouldBeTemporaryObject = false; + continue; + case DeclaratorChunk::BlockPointer: case DeclaratorChunk::MemberPointer: case DeclaratorChunk::Pipe: diff --git a/test/Parser/cxx-decl.cpp b/test/Parser/cxx-decl.cpp index 711a874f6a..58ad08079c 100644 --- a/test/Parser/cxx-decl.cpp +++ b/test/Parser/cxx-decl.cpp @@ -282,6 +282,22 @@ namespace NNS { } } +inline namespace ParensAroundFriend { // expected-error 0-1{{C++11}} + struct A {}; + struct B { + static A C(); + }; + namespace X { + struct B {}; + struct D { + // No warning here: while this could be written as + // friend (::B::C)(); + // we do need parentheses *somewhere* here. + friend A (::B::C()); + }; + } +} + // PR8380 extern "" // expected-error {{unknown linkage language}} test6a { ;// expected-error {{C++ requires a type specifier for all declarations}} diff --git a/test/SemaCXX/decl-expr-ambiguity.cpp b/test/SemaCXX/decl-expr-ambiguity.cpp index 1e31d701d0..b77e226b5d 100644 --- a/test/SemaCXX/decl-expr-ambiguity.cpp +++ b/test/SemaCXX/decl-expr-ambiguity.cpp @@ -125,3 +125,20 @@ void fizbin() { baz b3; // expected-error {{must use 'class' tag to refer to type 'baz' in this scope}} } } + +namespace TemporaryFromFunctionCall { + struct A { + A(int); + }; + int f(); + int g(int); + namespace N { + void x() { + // FIXME: For the first and second of these (but not the third), we + // should produce a vexing-parse warning. + A(f()); + A(g(int())); + A(g(int)); + } + } +}