From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 12 Dec 2016 16:23:23 +0000 (-0500)
Subject: Fix creative, but unportable, spelling of "ptr != NULL".
X-Git-Tag: REL_10_BETA1~1267
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=563d575fd73361f6118c13f2816988eba8e1f657;p=postgresql

Fix creative, but unportable, spelling of "ptr != NULL".

Or at least I suppose that's what was really meant here.  But even
aside from the not-per-project-style use of "0" to mean "NULL",
I doubt it's safe to assume that all valid pointers are > NULL.
Per buildfarm member pademelon.
---

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index c77b216d4f..5856e72918 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -13167,7 +13167,7 @@ ATExecAttachPartition(List **wqueue, Relation rel, PartitionCmd *cmd)
 	tupleDesc = RelationGetDescr(attachRel);
 	attachRel_constr = tupleDesc->constr;
 	existConstraint = NIL;
-	if (attachRel_constr > 0)
+	if (attachRel_constr != NULL)
 	{
 		int			num_check = attachRel_constr->num_check;
 		int			i;