From: Ted Kremenek <kremenek@apple.com>
Date: Sat, 15 Nov 2008 02:35:08 +0000 (+0000)
Subject: Re-enable an assertion that I mistakenly removed.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5631a73dbbcc49ee3c524eb5a96ac9f01324da1a;p=clang

Re-enable an assertion that I mistakenly removed.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@59348 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/GRExprEngine.cpp b/lib/Analysis/GRExprEngine.cpp
index b1272c2496..c6f7e9bc88 100644
--- a/lib/Analysis/GRExprEngine.cpp
+++ b/lib/Analysis/GRExprEngine.cpp
@@ -870,13 +870,7 @@ void GRExprEngine::VisitDeclRefExpr(DeclRefExpr* Ex, NodeTy* Pred, NodeSet& Dst,
     return;
 
   } else if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(D)) {
-    // FIXME: Does this need to be revised?  We were getting cases in
-    //  real code that did this.
-
-    // FIXME: This is not a valid assertion.  Produce a test case that
-    // refutes it.
-    // assert(asLValue); // Can we assume this?
-
+    assert(asLValue);
     SVal V = loc::FuncVal(FD);
     MakeNode(Dst, Ex, Pred, BindExpr(St, Ex, V));
     return;