From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Thu, 5 May 2016 22:46:25 +0000 (-0600)
Subject: Check lseek() return value.
X-Git-Tag: SUDO_1_8_17^2~107
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=562b5cb59b57ff726adcb24a99f448e7330ea997;p=sudo

Check lseek() return value.
Coverity CID 104061.
---

diff --git a/plugins/sudoers/timestamp.c b/plugins/sudoers/timestamp.c
index a2669fc4b..cf0b3d458 100644
--- a/plugins/sudoers/timestamp.c
+++ b/plugins/sudoers/timestamp.c
@@ -125,7 +125,12 @@ ts_find_record(int fd, struct timestamp_entry *key, struct timestamp_entry *entr
 	    sudo_debug_printf(SUDO_DEBUG_INFO|SUDO_DEBUG_LINENO,
 		"wrong sized record, got %hu, expected %zu",
 		cur.size, sizeof(cur));
-	    lseek(fd, (off_t)cur.size - (off_t)sizeof(cur), SEEK_CUR);
+	    if (lseek(fd, (off_t)cur.size - (off_t)sizeof(cur), SEEK_CUR) == -1) {
+		sudo_debug_printf(SUDO_DEBUG_ERROR|SUDO_DEBUG_ERRNO|SUDO_DEBUG_LINENO,
+		    "unable to seek forward %lld",
+		    (off_t)cur.size - (off_t)sizeof(cur));
+		break;
+	    }
 	    if (cur.size == 0)
 		break;			/* size must be non-zero */
 	    continue;
@@ -632,7 +637,11 @@ timestamp_lock(void *vcookie, struct passwd *pw)
 	cookie->locked = false;
 	cookie->key.type = TS_GLOBAL;	/* find a non-tty record */
 
-	(void)lseek(cookie->fd, 0, SEEK_SET);
+	if (lseek(cookie->fd, 0, SEEK_SET) == -1) {
+	    sudo_debug_printf(SUDO_DEBUG_ERROR|SUDO_DEBUG_ERRNO|SUDO_DEBUG_LINENO,
+		"unable to rewind fd");
+	    debug_return_bool(false);
+	}
 	if (ts_find_record(cookie->fd, &cookie->key, &entry)) {
 	    sudo_debug_printf(SUDO_DEBUG_DEBUG|SUDO_DEBUG_LINENO,
 		"found existing global record");
@@ -873,9 +882,10 @@ timestamp_remove(bool unlink_it)
 	/* Back up and disable the entry. */
 	if (!ISSET(entry.flags, TS_DISABLED)) {
 	    SET(entry.flags, TS_DISABLED);
-	    lseek(fd, 0 - (off_t)sizeof(entry), SEEK_CUR);
-	    if (ts_write(fd, fname, &entry, -1) == -1)
-		rval = false;
+	    if (lseek(fd, 0 - (off_t)sizeof(entry), SEEK_CUR) != -1) {
+		if (ts_write(fd, fname, &entry, -1) == -1)
+		    rval = false;
+	    }
 	}
     }