From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 2 Sep 2012 12:59:19 +0000 (+0200)
Subject: Fix bug with argparse.Parser.parse_args(*args)
X-Git-Tag: v3.3.0rc2~8
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=55c206ab2f2c8f0385dcc71054b3b42c3958b896;p=python

Fix bug with argparse.Parser.parse_args(*args)
---

diff --git a/Lib/argparse.py b/Lib/argparse.py
index cc3e374a66..67bbef2046 100644
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -1709,9 +1709,12 @@ class ArgumentParser(_AttributeHolder, _ActionsContainer):
         return args
 
     def parse_known_args(self, args=None, namespace=None):
-        # args default to the system args
         if args is None:
+            # args default to the system args
             args = _sys.argv[1:]
+        else:
+            # make sure that args are mutable
+            args = list(args)
 
         # default Namespace built from parser defaults
         if namespace is None:
diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
index fe930a3e8c..2e6584f5d9 100644
--- a/Lib/test/test_argparse.py
+++ b/Lib/test/test_argparse.py
@@ -4565,6 +4565,24 @@ class TestMessageContentError(TestCase):
 
 class TestParseKnownArgs(TestCase):
 
+    def test_arguments_tuple(self):
+        parser = argparse.ArgumentParser()
+        parser.parse_args(())
+
+    def test_arguments_list(self):
+        parser = argparse.ArgumentParser()
+        parser.parse_args([])
+
+    def test_arguments_tuple_positional(self):
+        parser = argparse.ArgumentParser()
+        parser.add_argument('x')
+        parser.parse_args(('x',))
+
+    def test_arguments_list_positional(self):
+        parser = argparse.ArgumentParser()
+        parser.add_argument('x')
+        parser.parse_args(['x'])
+
     def test_optionals(self):
         parser = argparse.ArgumentParser()
         parser.add_argument('--foo')