From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Mon, 27 Jul 2015 18:48:51 +0000 (+0300)
Subject: Don't assume that 'char' is signed.
X-Git-Tag: REL9_6_BETA1~1626
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5533a272ddecff18f16e9b6c307dcb2e130538f4;p=postgresql

Don't assume that 'char' is signed.

On some platforms, notably ARM and PowerPC, 'char' is unsigned by
default. This fixes an assertion failure at WAL replay on such platforms.

Reported by Noah Misch. Backpatch to 9.5, where this was broken.
---

diff --git a/src/include/access/spgist_private.h b/src/include/access/spgist_private.h
index 48dadd5b2c..fae10501a2 100644
--- a/src/include/access/spgist_private.h
+++ b/src/include/access/spgist_private.h
@@ -465,7 +465,7 @@ typedef struct spgxlogAddNode
 	 * -1: parent not updated
 	 *----
 	 */
-	char		parentBlk;
+	int8		parentBlk;
 	OffsetNumber offnumParent;	/* offset within the parent page */
 
 	uint16		nodeI;