From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Fri, 21 Aug 2020 03:25:18 +0000 (-0700)
Subject: disambiguate lib/ortho/*.c #includes
X-Git-Tag: 2.46.0~20^2^2~90^2~23
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=55240453f4393e9c7f6747f2d090f39e53d84a16;p=graphviz

disambiguate lib/ortho/*.c #includes

Related to #1242 and #1785.
---

diff --git a/lib/ortho/CMakeLists.txt b/lib/ortho/CMakeLists.txt
index 8e9407d6f..512c745ec 100644
--- a/lib/ortho/CMakeLists.txt
+++ b/lib/ortho/CMakeLists.txt
@@ -2,17 +2,6 @@ if (with_ortho)
 
 add_definitions(-D_BLD_gvc=1)
 
-include_directories(
-    ${CMAKE_CURRENT_SOURCE_DIR}
-    ${GRAPHVIZ_LIB_DIR}/cdt
-    ${GRAPHVIZ_LIB_DIR}/cgraph
-    ${GRAPHVIZ_LIB_DIR}/common
-    ${GRAPHVIZ_LIB_DIR}/gvc
-    ${GRAPHVIZ_LIB_DIR}/neatogen
-    ${GRAPHVIZ_LIB_DIR}/pack
-    ${GRAPHVIZ_LIB_DIR}/pathplan
-)
-
 add_library(ortho STATIC
     # Header files
     fPQ.h
@@ -34,4 +23,16 @@ add_library(ortho STATIC
     trapezoid.c
 )
 
-endif (with_ortho)
\ No newline at end of file
+target_include_directories(ortho PRIVATE
+    ${GRAPHVIZ_LIB_DIR}
+    ${CMAKE_CURRENT_SOURCE_DIR}
+    ${GRAPHVIZ_LIB_DIR}/cdt
+    ${GRAPHVIZ_LIB_DIR}/cgraph
+    ${GRAPHVIZ_LIB_DIR}/common
+    ${GRAPHVIZ_LIB_DIR}/gvc
+    ${GRAPHVIZ_LIB_DIR}/neatogen
+    ${GRAPHVIZ_LIB_DIR}/pack
+    ${GRAPHVIZ_LIB_DIR}/pathplan
+)
+
+endif (with_ortho)
diff --git a/lib/ortho/Makefile.am b/lib/ortho/Makefile.am
index f5b5883d9..9bd832cac 100644
--- a/lib/ortho/Makefile.am
+++ b/lib/ortho/Makefile.am
@@ -2,6 +2,7 @@
 ## Process this file with automake to produce Makefile.in
 
 AM_CPPFLAGS = \
+	-I$(top_srcdir)/lib \
         -I$(top_srcdir)/lib/common \
 	-I$(top_srcdir)/lib/gvc \
 	-I$(top_srcdir)/lib/neatogen \
diff --git a/lib/ortho/fPQ.c b/lib/ortho/fPQ.c
index 41d873c70..702fec68f 100644
--- a/lib/ortho/fPQ.c
+++ b/lib/ortho/fPQ.c
@@ -14,10 +14,10 @@
 /* Priority Queue Code for shortest path in graph */
 
 #include "config.h"
-#include <memory.h>
+#include <common/memory.h>
 #include <assert.h>
 
-#include "fPQ.h"
+#include <ortho/fPQ.h>
 
 static snode**  pq;
 static int     PQcnt;
diff --git a/lib/ortho/gvortho.vcxproj b/lib/ortho/gvortho.vcxproj
index ab5c5ae59..debb56b52 100644
--- a/lib/ortho/gvortho.vcxproj
+++ b/lib/ortho/gvortho.vcxproj
@@ -51,7 +51,7 @@
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <ClCompile>
       <Optimization>Disabled</Optimization>
-      <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)windows\include;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
       <PreprocessorDefinitions>_DEBUG;_LIB;WIN32_DLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <MinimalRebuild>true</MinimalRebuild>
       <BasicRuntimeChecks>EnableFastChecks</BasicRuntimeChecks>
@@ -66,7 +66,7 @@
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
     <ClCompile>
-      <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)windows\include;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>$(ProjectDir);$(SolutionDir)windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;$(SolutionDir)lib\gvc;$(SolutionDir)lib\pathplan;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
       <PreprocessorDefinitions>NDEBUG;_LIB;WIN32_DLL;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <PrecompiledHeader />
       <WarningLevel>Level4</WarningLevel>
diff --git a/lib/ortho/maze.c b/lib/ortho/maze.c
index e4a304883..e343f3f6e 100644
--- a/lib/ortho/maze.c
+++ b/lib/ortho/maze.c
@@ -17,11 +17,10 @@
 #define DEBUG
 
 #include <stddef.h>
-#include <maze.h>
-#include <partition.h>
-#include <memory.h>
-#include <arith.h>
-/* #include <values.h> */
+#include <ortho/maze.h>
+#include <ortho/partition.h>
+#include <common/memory.h>
+#include <common/arith.h>
 
 #define MARGIN 36;
 
diff --git a/lib/ortho/ortho.c b/lib/ortho/ortho.c
index 6ee462e69..39fc9edbf 100644
--- a/lib/ortho/ortho.c
+++ b/lib/ortho/ortho.c
@@ -27,13 +27,13 @@
 #define DEBUG
 #include <stddef.h>
 #include <setjmp.h>
-#include <maze.h>
-#include "fPQ.h"
-#include "memory.h"
-#include "geomprocs.h"
-#include "globals.h"
-#include "render.h"
-#include "pointset.h"
+#include <ortho/maze.h>
+#include <ortho/fPQ.h>
+#include <common/memory.h>
+#include <common/geomprocs.h>
+#include <common/globals.h>
+#include <common/render.h>
+#include <common/pointset.h>
 typedef struct {
     int d;
     Agedge_t* e;
@@ -513,7 +513,7 @@ addNodeEdges (sgraph* sg, cell* cp, snode* np)
 
 #ifdef DEBUG
 
-#include <intset.h>
+#include <common/intset.h>
 static char* bendToStr (bend b)
 {
   char* s = NULL;
@@ -1371,8 +1371,7 @@ orthofinish:
 }
 
 #ifdef DEBUG
-#include <arith.h>
-/* #include <values.h> */
+#include <common/arith.h>
 #define TRANS 10
 
 static char* prolog2 =
diff --git a/lib/ortho/partition.c b/lib/ortho/partition.c
index dfbb423f0..2a9c54552 100644
--- a/lib/ortho/partition.c
+++ b/lib/ortho/partition.c
@@ -13,9 +13,9 @@
 
 #include "config.h"
 
-#include <partition.h>
-#include <trap.h>
-#include <memory.h>
+#include <ortho/partition.h>
+#include <ortho/trap.h>
+#include <common/memory.h>
 #include <math.h>
 #include <stdlib.h>
 
diff --git a/lib/ortho/rawgraph.c b/lib/ortho/rawgraph.c
index ba3f7bc5c..d8e7b7b21 100644
--- a/lib/ortho/rawgraph.c
+++ b/lib/ortho/rawgraph.c
@@ -15,9 +15,9 @@
 
 #include "config.h"
 
-#include "rawgraph.h"
-#include "memory.h"
-#include "intset.h"
+#include <ortho/rawgraph.h>
+#include <common/memory.h>
+#include <common/intset.h>
 
 #define UNSCANNED 0
 #define SCANNING  1
diff --git a/lib/ortho/sgraph.c b/lib/ortho/sgraph.c
index 490b94910..152efa514 100644
--- a/lib/ortho/sgraph.c
+++ b/lib/ortho/sgraph.c
@@ -15,9 +15,9 @@
 #include "config.h"
 
 #include <limits.h>
-#include "memory.h"
-#include "sgraph.h"
-#include "fPQ.h"
+#include <common/memory.h>
+#include <ortho/sgraph.h>
+#include <ortho/fPQ.h>
 
 #if 0
 /* Max. number of maze segments around a node */
@@ -179,7 +179,7 @@ freeSGraph (sgraph* g)
     free (g);
 }
 
-#include "fPQ.h"
+#include <ortho/fPQ.h>
 
 /* shortest path:
  * Constructs the path of least weight between from and to.
diff --git a/lib/ortho/trapezoid.c b/lib/ortho/trapezoid.c
index 55ad3c62f..98bf455db 100644
--- a/lib/ortho/trapezoid.c
+++ b/lib/ortho/trapezoid.c
@@ -21,10 +21,10 @@
 #define __USE_ISOC99
 #endif
 #include <math.h>
-#include <geom.h>
-#include <logic.h>
-#include <memory.h>
-#include <trap.h>
+#include <common/geom.h>
+#include <common/logic.h>
+#include <common/memory.h>
+#include <ortho/trap.h>
 
 /* Node types */