From: Charles Kerr <charles@transmissionbt.com>
Date: Fri, 8 May 2009 20:52:12 +0000 (+0000)
Subject: (trunk libT) #2030: revert false alarm r8361 as per this suggestion http://trac.trans... 
X-Git-Tag: 1.61~12
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=54b7f9ccab94254b26fe155e328008f3ccee5643;p=transmission

(trunk libT) #2030: revert false alarm r8361 as per this suggestion http://trac.transmissionbt.com/ticket/2030#comment:45
---

diff --git a/libtransmission/rpc-server.c b/libtransmission/rpc-server.c
index a801e8f26..d4bc9a6e6 100644
--- a/libtransmission/rpc-server.c
+++ b/libtransmission/rpc-server.c
@@ -335,7 +335,13 @@ serve_file( struct evhttp_request * req,
         content_len = 0;
         content = tr_loadFile( filename, &content_len );
 
-        if( content )
+        if( errno )
+        {
+            char * tmp = tr_strdup_printf( "%s (%s)", filename, tr_strerror( errno ) );
+            send_simple_response( req, HTTP_NOTFOUND, tmp );
+            tr_free( tmp );
+        }
+        else
         {
             struct evbuffer * out;
             const time_t now = time( NULL );
@@ -351,12 +357,6 @@ serve_file( struct evhttp_request * req,
             tr_releaseBuffer( out );
             tr_free( content );
         }
-        else
-        {
-            char * tmp = tr_strdup_printf( "%s (%s)", filename, tr_strerror( errno ) );
-            send_simple_response( req, HTTP_NOTFOUND, tmp );
-            tr_free( tmp );
-        }
     }
 }
 
@@ -583,8 +583,7 @@ handle_request( struct evhttp_request * req, void * arg )
                 "<p style=\"padding-left: 20pt;\">This requirement has been added to make "
                 "<a href=\"http://en.wikipedia.org/wiki/Cross-site_request_forgery\">CSRF</a>"
                 " attacks more difficult.</p>",
-                TR_RPC_SESSION_ID_HEADER, sessionId,
-                TR_RPC_SESSION_ID_HEADER );
+                TR_RPC_SESSION_ID_HEADER, sessionId );
             evhttp_add_header( req->output_headers, TR_RPC_SESSION_ID_HEADER, sessionId );
             send_simple_response( req, 409, tmp );
             tr_free( tmp );
diff --git a/libtransmission/utils.c b/libtransmission/utils.c
index 93f05f055..c0a1cf7e2 100644
--- a/libtransmission/utils.c
+++ b/libtransmission/utils.c
@@ -289,13 +289,11 @@ tr_msgLoggingIsActive( int level )
 }
 
 void
-tr_msg( const char * file,
-        int          line,
-        int          level,
-        const char * name,
-        const char * fmt,
-        ... )
+tr_msg( const char * file, int line,
+        int level, const char * name,
+        const char * fmt, ... )
 {
+    const int err = errno; /* message logging shouldn't affect errno */
     FILE * fp;
     tr_msgInit( );
     tr_lockLock( messageLock );
@@ -350,6 +348,7 @@ tr_msg( const char * file,
     }
 
     tr_lockUnlock( messageLock );
+    errno = err;
 }
 
 /***