From: Georg Brandl <georg@python.org>
Date: Fri, 31 Mar 2006 20:00:11 +0000 (+0000)
Subject: bug #1461855: make os.fdopen() add the O_APPEND flag if using "a" mode.
X-Git-Tag: v2.5a1~112
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=54a188aed8cc8333927a679bb00eda4e25aa0cba;p=python

bug #1461855: make os.fdopen() add the O_APPEND flag if using "a" mode.
glibc, for example, does this already on its own, but it seems that
the solaris libc doesn't. This leads to Python code being able to over-
write file contents even though having specified "a" mode.
---

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index abf69a98de..631833f77a 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5768,9 +5768,20 @@ posix_fdopen(PyObject *self, PyObject *args)
 			     "invalid file mode '%s'", mode);
 		return NULL;
 	}
-
 	Py_BEGIN_ALLOW_THREADS
-	fp = fdopen(fd, mode);
+	if (mode[0] == 'a') {
+		/* try to make sure the O_APPEND flag is set */
+		int flags;
+		flags = fcntl(fd, F_GETFL);
+		if (flags != -1)
+			fcntl(fd, F_SETFL, flags | O_APPEND);
+		fp = fdopen(fd, mode);
+		if (fp == NULL)
+			/* restore old mode if fdopen failed */
+			fcntl(fd, F_SETFL, flags);
+	} else {
+		fp = fdopen(fd, mode);
+	}
 	Py_END_ALLOW_THREADS
 	if (fp == NULL)
 		return posix_error();