From: Mark Hansen <markhansen@google.com>
Date: Mon, 14 Nov 2022 10:50:40 +0000 (+1100)
Subject: Give better names to mapBool arguments
X-Git-Tag: 7.0.2~8^2~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=5466adcf2b88e0d3b8bfd97ece4d1706754beaf3;p=graphviz

Give better names to mapBool arguments
---

diff --git a/lib/common/utils.c b/lib/common/utils.c
index d30ca3c8d..f36ac1475 100644
--- a/lib/common/utils.c
+++ b/lib/common/utils.c
@@ -384,10 +384,9 @@ int maptoken(char *p, char **name, int *val)
     return val[i];
 }
 
-bool mapBool(const char *p, bool dflt)
-{
+bool mapBool(const char *p, bool defaultValue) {
     if (!p || *p == '\0')
-	return dflt;
+        return defaultValue;
     if (!strcasecmp(p, "false"))
 	return false;
     if (!strcasecmp(p, "no"))
@@ -399,7 +398,7 @@ bool mapBool(const char *p, bool dflt)
     if (isdigit((int)*p))
 	return atoi(p) != 0;
     else
-	return dflt;
+        return defaultValue;
 }
 
 bool mapbool(const char *p)
diff --git a/lib/common/utils.h b/lib/common/utils.h
index 76c77bfcd..d27d9f36a 100644
--- a/lib/common/utils.h
+++ b/lib/common/utils.h
@@ -90,8 +90,8 @@ UTILS_API void UF_setname(Agnode_t *, Agnode_t *);
 UTILS_API char *Fgets(FILE *fp);
 UTILS_API const char *safefile(const char *filename);
 
-UTILS_API bool mapBool(const char*, bool);
-UTILS_API bool mapbool(const char*);
+UTILS_API bool mapBool(const char *p, bool defaultValue);
+UTILS_API bool mapbool(const char *p);
 UTILS_API int maptoken(char *, char **, int *);
 
 UTILS_API bool findStopColor(char *colorlist, char *clrs[2], float *frac);