From: Steve Naroff <snaroff@apple.com>
Date: Mon, 11 Feb 2008 02:42:07 +0000 (+0000)
Subject: Add a comment/FIXME to an earlier change.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=54174e8439d22c87639195410619ec7128e293b4;p=clang

Add a comment/FIXME to an earlier change.



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@46947 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/Sema/SemaDecl.cpp b/Sema/SemaDecl.cpp
index c6f1203e68..c427a81306 100644
--- a/Sema/SemaDecl.cpp
+++ b/Sema/SemaDecl.cpp
@@ -527,7 +527,11 @@ bool Sema::CheckInitializerListTypes(InitListExpr*& IList, QualType &DeclType,
       } else {
         RecordDecl* structDecl = DeclType->getAsRecordType()->getDecl();
         
-        // If the record is invalid, it's members can't be trusted. 
+        // If the record is invalid, it's members can't be trusted.
+        // FIXME: I'd like to "fix" this at a higher level. That is, we should
+        // never get here if the struct decl is invalid. Considering a
+        // change to Type::isIncompleteType(). Until this happens, the 
+        // following check is certainly better than crashing.
         if (structDecl->isInvalidDecl())
           return true;